dataplane: make hook kubectl image configurable#467
Open
xjerod wants to merge 1 commit into
Open
Conversation
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Add image.kubectl values for dataplane Helm hook cleanup jobs and use them in the pre-upgrade and pre-delete hooks. This allows overriding the kubectl repository, tag, pull policy, and imagePullSecrets. Add a generated test fixture that renders the hook jobs with a custom kubectl image and teach the test generator to pass optional helm args from values-file headers.
xjerod
force-pushed
the
jerod/kubectl-hook
branch
from
347b740 to
06fda59
Compare
chloe-kx
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add image.kubectl values for dataplane Helm hook cleanup jobs and use them in the pre-upgrade and pre-delete hooks. This allows overriding the kubectl repository, tag, pull policy, and imagePullSecrets.
Add a generated test fixture that renders the hook jobs with a custom kubectl image and teach the test generator to pass optional helm args from values-file headers.