Merge pull request #323 from unionai/main#324
Open
fiedlerNr9 wants to merge 38 commits into
Open
Conversation
Contributor
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
…ues file Documents how to configure the identity service with provider: azure when using Entra ID, using outputs from the authn/entraid Terraform module. Includes an extraObjectsOverrides ExternalSecret example to merge the Graph API client secret from GCP Secret Manager into the shared K8s secret. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add service override to suppress dangling connect port (83) that would have targeted a non-existent named container port - Fix azure clientSecretName example: remove erroneous union/ prefix (K8s secret keys cannot contain slashes) - Remove FLYTEADMIN_ENDPOINT reference from base values; endpoint is environment-specific and should be set via overlay values Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The identity service registers both gRPC and Connect hooks. Both defaulted to port 8080 causing a bind conflict on startup. Add sharedService.connectPort: 8081 to move the Connect server to 8081. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The upstream flyte-core chart doesn't render the `private` config section into a separate YAML file. This adds a new ConfigMap template that renders `.Values.flyte.configmap.adminServer.private` into `private.yaml` and mounts it at `/etc/flyte/config/private.yaml` via additionalVolumeMounts. This enables flyteadmin-private config like `logoutUrl` and `supportsTokenRevocation` to be read from Helm values rather than requiring changes to the flyte-core subchart. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Mount private-config to /etc/flyte/private/ instead of attempting a subPath mount into /etc/flyte/config/ which conflicts with the existing clusters-config-volume projected mount. Update configPath to /etc/flyte/*/*.yaml to include both config directories. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ab59003 to
67b52c2
Compare
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
9a5f5a2 to
4c2636a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update