Skip to content

Changed venv installation to use uv#7

Open
darryllam wants to merge 9 commits intounilight:mainfrom
darryllam:main
Open

Changed venv installation to use uv#7
darryllam wants to merge 9 commits intounilight:mainfrom
darryllam:main

Conversation

@darryllam
Copy link
Copy Markdown

Thank you for developing such a convenient toolkit. When trying to install the toolkit, I was encountering some dependency issues. I used the uv dependency manager to fix my issues and I hope this can help others as well with the installation process.

@unilight
Copy link
Copy Markdown
Owner

Hi @darryllam, thanks for the PR!

I don't have muchh experience with uv, but it seems to be pretty convenient!
Just wondering -- is it possible to keep both installation methods?

Also I noticed that you put sheet under src/sheet. May I ask what is the reason for that?

@darryllam
Copy link
Copy Markdown
Author

The reason why sheet was moved to src/sheet is because uv expects the source code to be in src in order to have the package importable in the python environment as sheet. Theoretically, it should be possible to keep both installation methods if the change in file structure does not affect the current installation method.

@eginhard
Copy link
Copy Markdown

eginhard commented Nov 4, 2025

uv should handle both a src and a flat layout, I don't think changing that is necessary.

Just wondering -- is it possible to keep both installation methods?

Everything in the pyproject.toml is Python standard, so installation with pip install . or any other package manager works as well.

Comment on lines +6 to +13
name = "sheet"
version = "0.1.0"
description = "Speech Human Evaluation Estimation Toolkit (SHEET)"
requires-python = "==3.10.13"

authors = [
{ name = "Your Name", email = "your.email@example.com" }
]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use the correct metadata from https://github.com/unilight/sheet/blob/main/setup.cfg (which can be deleted afterwards)

Copy link
Copy Markdown
Author

@darryllam darryllam Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left the name field as sheet as it appears that some of the scripts within the package reference sheet rather than sheet_sqa. The other changes are now reflected in the latest push

…pdendencies to optional in pyproject.toml and added metadata
@unilight
Copy link
Copy Markdown
Owner

unilight commented Nov 6, 2025

Hi, (again I am not familiar with uv at all, but if what @eginhard suggested is correct then) it will be super nice to (1) keep the sheet/ structure rather than changing to src/sheet (2) keep tools/venv so we don't need to update every path.sh.

@darryllam
Copy link
Copy Markdown
Author

I believe that I have made the requested changes now. Let me know if there are any other changes that are needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants