Update lib.rs doc comments#168
Merged
Manishearth merged 2 commits intounicode-rs:masterfrom Mar 30, 2026
Merged
Conversation
atouchet
commented
Mar 30, 2026
| // option. This file may not be copied, modified, or distributed | ||
| // except according to those terms. | ||
|
|
||
| //! Iterators which split strings on Grapheme Cluster, Word or Sentence boundaries, according |
Contributor
Author
There was a problem hiding this comment.
This wording was added in 7ac6f29 for lib.rs but not the readme. Is the version with "Sentence" better to use or should the readme version be used here?
Contributor
Author
There was a problem hiding this comment.
I opted to change this in the readme instead.
Manishearth
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this doc comment had gotten out of date with the version in the readme. This aligns them so they are the same.