Don't generate tables in the build.rs (do so in advance).#16
Closed
thomcc wants to merge 1 commit intounicode-rs:masterfrom
Closed
Don't generate tables in the build.rs (do so in advance).#16thomcc wants to merge 1 commit intounicode-rs:masterfrom
thomcc wants to merge 1 commit intounicode-rs:masterfrom
Conversation
thomcc
commented
Jul 7, 2020
Author
|
Ah, there's already a PR for unicode version bump in #14. I'll drop that commit from mine then. |
thomcc
changed the title
Author
|
r? @SimonSapin (gentle nudge) |
Contributor
|
Found this when investigating compile time for RustPython. Looks like SimonSapin has transferred the project to unicode-rs. @Manishearth, does this change seem reasonable to you? |
Manishearth
approved these changes
Sep 23, 2024
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
This seems fine. Could you also add CI that checks the codegen is up to date?
Contributor
|
@Manishearth, thanks for the suggestion. I can't edit this pr, so created #21 with a workflow. Verified it by manually messing up the file on my own branch: https://github.com/crazymerlyn/rust-caseless/actions/runs/12504550179 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regexis a pretty slow dependency to build (well,regex-syntaxis anyway), and it's pretty unnecessary for this crate to generate the table each time it builds.I did this by just moving your build.rs to its own crate, which dumps the table to stdout (because it's easy, flexible, but mostly harder to mess up than taking a file argument. Although if you'd rather I do that, I can).
For clarity,
cargo run -p print-table > src/case_folding_data.rscan update the pre-generated table.Oh, also I updated you to unicode 13.0.0. I did it just because seems like good manners to do so when I'm updating the tables anyway, but I can undo it if you'd prefer.