Move unicodeset_parse to icu_properties#7935
Merged
robertbastian merged 4 commits intounicode-org:mainfrom May 5, 2026
Merged
Conversation
Manishearth
reviewed
May 4, 2026
| mod harfbuzz; | ||
|
|
||
| #[cfg(feature = "unstable")] | ||
| pub mod unicodeset_parse; |
Member
There was a problem hiding this comment.
nit: should be called unstable_
also needs scary unstable header
Manishearth
approved these changes
May 4, 2026
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
Seems fine. This doesn't seem to be modifying provider/source, but when that happens we will need to access this code through doc(hidden) pub mod unstable_internal so that datagen doesn't need unstable features.
Member
Author
datagen already uses unstable features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3959
Changelog
icu_properties: