Repository navigation
Conversation
uniblab
marked this pull request as ready for review
October 24, 2026 03:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Move
sedGNU BRE/ERE address and substitution matching to publishedIcod.Expressions 0.1.0-alpha.1. CommandFramework continues to supply command, diagnostic, IO, process, and locale text contracts, includingITextLocaleProvider/TextDecodingMode. CLI and byte/locale behavior are preserved. This PR is stacked on #6, which prepares the2.0.0-alpha.1prerelease and the exact tool package verification; retarget to main after #6 merges. Later API refactoring remains possible.Validation
Test-first run 40058131776 failed the private matcher assembly-identity assertion on Linux and macOS as expected (actual
Icod.CommandFramework, expectedIcod.Expressions). Final run 40058300306 passed full solution Staging builds and tests on Linux, Windows, and macOS, plus Linux package verification and archive smoke. Existing Sed suites cover BRE/ERE addresses, substitutions, NUL records and byte/UTF-8 locale behavior. Independent review found no blocking regression.grepremains last pending in-house PCRE.