Fix Snappy decompressor buffer corruption and add ClickBench tests#36
Merged
Fix Snappy decompressor buffer corruption and add ClickBench tests#36
Conversation
Snappy fix: - The decompressor was sharing the same buffer for both the circular window (for back-references) and the Reader's internal buffer. - When the Reader framework used the buffer, it corrupted the window. - Fix: Use separate buffer regions - first 128KB for the window, remaining 4KB for the Reader's output buffer. - Increased window to 128KB to support copy 4-byte test (offset 65540). ClickBench dataset: - Added ClickBench web analytics dataset (3 parquet files, ~450MB total) - 105 columns with diverse types, real-world 'dirty' data - CI-only tests that read all columns from all row groups - Updated download script and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes buffer corruption issues in the Snappy decompressor that occurred when processing large files with copy operations.
Changes
Snappy Decompressor Fix
copy.offset > d.total_written or copy.offset == 0)remaining == 0in both literal and copy statesinit()ClickBench Conformance Tests
Testing