fix(evals): keep large benchmark viewers bounded - #478
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large trace-derived evals now finish packaging instead of crashing while generating their optional HTML review viewer. Small benchmarks remain self-contained; large benchmarks retain capture bodies in their existing sidecar files and load them through
understudy traces serve --benchmark.Root cause
The viewer embedded every normalized capture and serialized the entire payload into one JavaScript string. The reproduced workload's 7,036 captures totaled more than Node's roughly 512 MiB single-string limit, so
build-benchmarkstopped before writing its final manifest and goal event even though the core eval artifacts had already been created.What changed
Validation
node --test tests/trace-foundry.test.mjs— 62/62 passed.npm run typechecknpm run skills:validate— 43 public skills passed.npm run package:smokegit diff --check