fix(capture-import): emit forward-slash artifact references in workload cards - #472
Open
Tyagiquamar wants to merge 1 commit into
Open
fix(capture-import): emit forward-slash artifact references in workload cards#472Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
artifactReference()insrc/capture-import.tsreturnspath.relative(repo, …)verbatim when it builds the metadata-only workload card's discovery fields (discovery.evidence_paths,capture_sources,redaction_manifest). On Windows that embeds backslash-separated paths like:The workload card is a portable artifact (shared with the gateway via
workloads create --from-card, checked into repos, read by agents on any OS), so native separators leak platform-specific paths into its JSON contract. This is the same conventionsrc/benchmark-artifacts.tsalready normalizes away (rel.split(sep).join("/")) for emitted artifacts.Found by running the test suite on Windows:
tests/cli.test.mjs"builds a capture/import workload card from the scan manifest" asserts.understudy/capture-import/redaction-manifest.jsonand fails against the backslashed value.Fix
Normalize the repo-relative reference to forward slashes before returning it (
split(sep).join("/"), matching the existing idiom inbenchmark-artifacts.ts). The out-of-repo fallback branch is untouched. The pre-existing../-prefix check now runs after normalization, so it also correctly catches Windows..\escapes through one code path.Testing
On Windows 11, Node 24: