Add ability to supply custom cloing logic#13
Open
watson wants to merge 1 commit intounclechu:masterfrom
Open
Conversation
3f0710c to
8b9ebc5
Compare
Owner
|
@watson How about different interface? Something like this?: var deepExtend = require('deep-extend');
var customExtend = deepExtend.customExtender(cloner);
var standardCloned = deepExtend({}, obj); // standard behavior
var customCloned = customExtend({}, obj); // with custom logicIt will save backward compatibility. |
Author
|
That's not such a bad idea... you could also do it with a submodule like in is-my-json-valid: var deepExtend = require('deep-extend');
var customExtend = require('deep-extend/custom')(cloner);
var standardCloned = deepExtend({}, obj); // standard behavior
var customCloned = customExtend({}, obj); // with custom logicI kind of prefer the latter since adding a function to a custom property on the normal deepExtend function seems a little hack'ish. But I might be wrong. I can update the pull request with which ever version you prefer? |
Owner
|
@watson Last version is better. var deepExtend = require('deep-extend');
var customExtend = require('deep-extend/custom')(cloner); |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning: This is a highly opinionated change so I understand if it doesn't fit the vision of this module. Also it should be released as a breaking change due to the new initializer function.
My use case is that I use deep-extend to clone MongoDB documents. They contain custom MongoDB types like
TimestampandObjectId. This module will think they are regular object literals and extend them like any other object literal. This unfortunately means that they lose their relation to their original classes so you no longer can do anobj instanceof Klass.This pull request adds new functionality which allows you to supply a custom cloning function which will be called for each value that deep-extend attempts to clone. If the cloning function returns a falsy value the regular behaviour of deep-extend is used, but if the cloning function returns any truthy value, that value will be used as the new value: