chore: add CI preflight gate and pin action SHAs#26
Open
jflowers wants to merge 1 commit into
Open
Conversation
- Switch release trigger from push-tag to workflow_dispatch with preflight validation (branch, tag format, uniqueness, semver ordering, CI status, unreleased commits) - Pin all action references to full commit SHAs - Rename CI job to "Build and Test" (org convention) - Add permissions and concurrency blocks to CI workflow - Scope release workflow permissions per-job - Update constitution to reflect new release trigger - Include OpenSpec artifacts and retrospective learnings Fixes: unbound-force#15 Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Jay Flowers <jay.flowers@gmail.com>
fc6df19 to
023276d
Compare
gxmiranda
approved these changes
Jun 18, 2026
gxmiranda
left a comment
There was a problem hiding this comment.
Clean CI/CD hardening change. SHA pins independently verified against GitHub API (all 3 match claimed versions). Shell injection patterns are correct — all untrusted inputs use env bindings, no ${{ }} in run blocks. Permissions follow deny-by-default with per-job scoping. Preflight validation covers branch, tag format, uniqueness, semver ordering, CI status, and unreleased commits with idempotent re-run support. Constitution updated to reflect new trigger.
This review was generated by /review-pr (AI-assisted).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the tag-push release trigger with a workflow_dispatch preflight
gate and pin all GitHub Actions to commit SHAs.
Summary
push: tags: ['v*']toworkflow_dispatchwith a
taginputsemver ordering, CI status, unreleased commits, tag creation, signing secrets
v6.4.0, goreleaser-action v7.2.2)
testtoBuild and Test(org convention)permissions:andconcurrency:blocks to CI workflowBreaking Change
Releases can no longer be triggered by pushing a tag. Use:
gh workflow run release.yml -f tag=vX.Y.ZFixes: #15
Assisted-by: OpenCode (claude-opus-4-6)