feat: add CDE demo endpoints, fix Ollama connectivity, auto-start server#6
Merged
Conversation
- Add public demo endpoints (3000, 8080, 8443) to both devfiles - Replace hardcoded host.containers.internal with empty default for CDE/Kubernetes compatibility - Add composite postStart commands for sequential init + server start - Document CDE endpoints and Ollama configuration in README Closes #3
govulncheck v1.2.0 exits non-zero with -version when no Go module is present in the working directory (prints 'no package patterns provided'). Use 'which' for existence check instead.
Same govulncheck v1.2+ exit code issue as install script. Use --entrypoint which for existence check instead of running govulncheck -version which fails without a Go module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses all three gaps identified in Issue #3 for CDE (Eclipse Che / Dev Spaces) devfiles:
demo-http(3000),demo-api(8080),demo-alt(8443) — to both devfileshost.containers.internal(Podman-only, fails in K8s) with empty default. Documented per-environment configurationinit-workspace→start-server, orinstall-tools→init-workspace→start-serverfor dynamic variant)Review Council
compositecommand for guaranteed sequential execution (per devfile 2.2.0 spec)Files Changed
devfile.yamldevfile-dynamic.yamlREADME.mdopenspec/changes/cde-endpoints/Closes #3