Skip to content

fix: highlight the palette row under the pointer #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umputun merged 1 commit into from
Aug 9, 2026
+13 −1
Merged

fix: highlight the palette row under the pointer #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion agterm/Views/Palette.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,17 @@ private struct PaletteRow: View {
let item: PaletteItem
let isSelected: Bool
let metrics: InterfaceMetrics
@State private var hovering = false

/// A neutral wash rather than a weaker accent: hover and the accent-tinted selection can sit on different
/// rows at once, so the same hue at two strengths would read as a second selection. It also has to hold up
/// over both panel backings, `.regularMaterial` and the opaque Reduce Transparency one.
private static let hoverTint = Color.primary.opacity(0.04)

private var rowTint: Color {
if isSelected { return Color.accentColor.opacity(0.25) }
return hovering ? Self.hoverTint : .clear
}

var body: some View {
HStack {
Expand Down Expand Up @@ -370,8 +381,9 @@ private struct PaletteRow: View {
.padding(.horizontal, metrics.scaled(12))
.padding(.vertical, metrics.scaled(6))
.frame(maxWidth: .infinity, alignment: .leading)
.background(isSelected ? Color.accentColor.opacity(0.25) : Color.clear)
.background(rowTint)
.contentShape(Rectangle())
.onHover { hovering = $0 }
.accessibilityIdentifier("palette-item-\(item.id)")
}
}
Loading