Skip to content

fix(tests): stop AppKit rewriting the uppercase-key-equivalent fixture #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skkap wants to merge 1 commit into from
Closed

fix(tests): stop AppKit rewriting the uppercase-key-equivalent fixture #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion agtermTests/LiveMenuKeyEquivalentsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,13 @@ final class LiveMenuKeyEquivalentsTests: XCTestCase {

// AppKit matches an uppercase key equivalent against the SHIFTED chord even with shift absent from
// the mask, so lowercasing without adding shift would name a chord the item can never fire.
//
// The title must NOT be one AppKit recognises as a standard menu item ("Paste and Match Style" was,
// and is why this used to fail): `NSMenu.addItem` rewrites such an item to the system-standard
// equivalent, turning ⌥⌘V into ⇧⌘V before the code under test ever sees it — a fixture that
// silently stops testing what it says. The rewrite keys off the title alone, not the chord.
func testUppercaseKeyEquivalentReportsImpliedShift() throws {
let file = menu("Edit", [item("Paste and Match Style", key: "V", mods: [.command, .option])])
let file = menu("Edit", [item("Vendor Paste Special", key: "V", mods: [.command, .option])])

let found = try XCTUnwrap(ControlServer.collectKeyEquivalents(in: file, menu: "Edit").first)

Expand Down
Loading