Optimize persistent connection registry for 8-10% performance gains#23
Open
AnotherRegularDude wants to merge 6 commits intomasterfrom
Open
Optimize persistent connection registry for 8-10% performance gains#23AnotherRegularDude wants to merge 6 commits intomasterfrom
AnotherRegularDude wants to merge 6 commits intomasterfrom
Conversation
Pull Request Test Coverage Report for Build 16252854548Details
💛 - Coveralls |
skirushkin
approved these changes
Jul 15, 2025
tycooon
reviewed
Jul 15, 2025
| # ... make some requests ... | ||
|
|
||
| # Close all persistent connections and clear caches | ||
| client.truncate! |
Member
There was a problem hiding this comment.
А почему это называется truncate? Мб лучше как-то типа reset?
|
|
||
| def get_origin(url) | ||
| HTTP::URI.parse(url).origin | ||
| origin_cache[url] ||= HTTP::URI.parse(url).origin |
Member
There was a problem hiding this comment.
А если у меня урлы каждый раз будут разные (типа гет запросы с рандомным гуидом в урле) – память в итоге закончится?
0exp
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
compare_by_identityfor SSL certificatesregistry[origin][ssl_bucket]with flat compound keys3.1: https://www.ruby-lang.org/en/downloads/branchesBenchmarks
Look at
bin/benchmarkexecutable file.