Repository navigation
test(ui): make the FlaUI suite pass again, without the mouse or keyboard - #184
Merged
Merged
Conversation
All ten UI tests were failing. Not a product bug: the tests had drifted from the app, and nothing runs them in CI. - Dialogs are owned by the main window, so UI Automation lists them under it, not at the top level. FindDialog searches both. - Border / StackPanel / Grid have no automation peer, so the AutomationIds on SidebarSessionList and TerminalGrid were never visible. Views/UiaElements adds peer-carrying subclasses; sidebar rows, dormant rows, terminal panes, the pane close button and the empty-state text get ids. - Buttons are pressed through the Invoke pattern instead of mouse clicks, and sessions are closed with the pane's close button instead of a synthesized Ctrl+W: keystrokes fail with "Access is denied" on a locked desktop. - EmptyState was matched by an exact name its two-line text never had. 10/10 pass, run on a locked screen. Unit tests 765/765. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsYm9iLc2aRnRDfV2uZRQX
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsYm9iLc2aRnRDfV2uZRQX
3 tasks
Merged
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 10 FlaUI UI tests were failing when run after the v0.10.0 release. Not a product bug: the tests had drifted from the app, and nothing runs them in CI.
Causes and fixes
GetAllTopLevelWindowsnever found them ("dialog did not open").AppActions.FindDialogsearches both.Border,StackPanelandGridare invisible to UIA, so theSidebarSessionList/TerminalGridids were ignored. NewViews/UiaElements(UiaBorder/UiaStackPanel/UiaGrid: same element plus a Group peer, no layout change). Ids added for sidebar rows (SidebarSessionRow,SidebarDormantRow), panes (TerminalPane), the pane close button (TerminalCloseBtn) andEmptyState.EmptyStatewas matched by an exact name its two-line text never had.CLAUDE.md "Testing" documents the three traps.
Verification
🤖 Generated with Claude Code
https://claude.ai/code/session_01NsYm9iLc2aRnRDfV2uZRQX