Repository navigation
chore: v0.10.0 release prep — second review round, README, CI manifest check - #183
Merged
Merged
Conversation
…check Second-round review (fresh eyes on the #182 fixes) and a release-facing review: - Worktree remove's nested check failed OPEN: ListWorktreesAsync returns empty on any git error, which read as "nothing nested". It now refuses unless the freshly read list contains the target. - It only saw worktrees registered with the same repo. An independent clone or another repo's worktree in an ignored folder was still deleted silently. GitWorktrees.NestedRepositories scans the folder for any .git of its own (no junction following, never into .git, capped — over the cap it refuses). - Stale comment: restart is no longer the only removeOnFailure: false caller. Docs: README feature list gains the git chip/menu, Worktrees menu, Open in VS Code / Explorer / PowerShell, drag-and-drop ordering and the full bulk-action list; worktrees re-rated "one click, not automatic" in README and comparison. CI: after Publish, fail if the SHIPPED exe lacks the PerMonitorV2 manifest — the unit test only pins it into the build output (verified by hand that the single-file publish keeps it). Tests: independent clone + submodule found, plain worktree and a junction to a repo not, cap returns null. 765/765. End-to-end remove re-run in the app. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NsYm9iLc2aRnRDfV2uZRQX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last changes before tagging v0.10.0: fixes from a second review round, the README brought up to date with this release, and a CI guard on the shipped exe.
Why
Second review round, with fresh eyes on #182's fixes. Worktree remove's nested-repo guard had two gaps:
ListWorktreesAsyncreturns empty on any git error, which read as "nothing nested". It now refuses unless the freshly read list contains the target.GitWorktrees.NestedRepositoriesnow scans the folder for any.gitof its own. It doesn't follow junctions, never walks into.git, and refuses if it hits its folder cap.Release-facing review:
Implementation notes
docs/comparison.mdnow say "one click, not automatic".build.ymlfails the tag build if the published exe lacks thePerMonitorV2manifest. I checked by hand that a local single-file publish keeps it, runs per-monitor aware, and works with a live session.removeOnFailure: falsecaller.Test plan
{ }are present.🤖 Generated with Claude Code
https://claude.ai/code/session_01NsYm9iLc2aRnRDfV2uZRQX