Repository navigation
Suppress Slack notifications on workflow reruns - #212
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Reviewed the notification job condition in .github/workflows/publish.yml. It limits Slack notifications to the first workflow attempt without restricting retry work. LGTM.
|
🎉 This PR has been merged! Thanks, @glenn-jocher, for adding a guard that prevents duplicate Slack notifications on workflow reruns.
A focused change that limits notifications to the first run attempt while preserving the existing checks. |
Workflow re-runs could send duplicate Slack notifications. Restrict the existing notification owner to the first run attempt, covering both success and failure while preserving the work performed by retries.
Validation: parsed the changed YAML, checked the diff, and compared actionlint results with the base; no new diagnostics.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
The publish workflow now limits its Slack notification job to the first run attempt to prevent duplicate notifications on reruns.
📊 Key Changes
github.run_attempt == '1'condition to thenotifyjob.always()and increment checks, so the job can still run after success or failure when those checks pass.🎯 Purpose & Impact