Conversation
jdulb
reviewed
Aug 31, 2017
| } | ||
| else print "Audio creation of ".$slidepath.".wav from ".$slidepath." SUCCEED. \n"; | ||
| else | ||
| print "Audio creation of ".$slidepath.".wav from ".$slidepath." SUCCEED. \n"; |
Collaborator
There was a problem hiding this comment.
Tu peux remplacer les \n par des PHP_EOL en général, c'est mieux pour la portabilité du code
jdulb
reviewed
Aug 31, 2017
| print "Move ".$slidepath." from ".$movies_path."/slidetemp.mov failed. \n"; | ||
|
|
||
| exec('cp '.$movies_path.'/camtemp.mov '.$campath,$err,$return); | ||
| if ($return != 0) |
Collaborator
There was a problem hiding this comment.
Reste des tabs ici je pense :p
jdulb
reviewed
Aug 31, 2017
| print "Move ".$campath." from ".$movies_path."/camtemp.mov failed. \n"; | ||
|
|
||
|
|
||
| //use to replace the cam song with the slide song |
Collaborator
There was a problem hiding this comment.
Plutôt "sound" plutôt que "song" ? ici et dans les occurences suivantes
Collaborator
|
Je note que la config se fait sur le renderer, quid du jour où vous installez des nouvelles salles avec des caméras dont le son est ok ? Peut-etre qu'à ce moment là vous voudrez quand même garder la config et override le sons de celle là aussi, je pose juste la question au cas où :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copy sound from slide to cam if ( $enable_audio_sync == true && $copy_sound_from_slide_to_cam == true)
In case of sound from camera is not good