This repository was archived by the owner on Mar 21, 2019. It is now read-only.
compose: fix lookupproxy deployment#139
Merged
msb merged 2 commits intouisdevops:masterfrom Jul 19, 2018
Merged
Conversation
The lookupproxy compose configuration was only semi-functional. Since we're going to need to re-deploy the lookupproxy in development *anyway* to bring in the django-automationoauth fixes, fix up the configuration so that it can use the upstream production image. This should further reduce CircleCI build times and also means that lookupproxy actually works in development. Previously it didn't since the OAuth2 configuration was not being set.
Member
|
This is relying on the docker hub's lookupproxy, the last time we checked that wasn't working properly and it was not building for every push to master and we had to quick it manually. Has this changed now? |
abrahammartin
requested review from
abrahammartin
and removed request for
a team
msb
approved these changes
Jul 18, 2018
Member
Author
|
It seems to have worked last time I checked, but in any case if the lookupproxy image isn't building, then that's a separate issue: uisdevops/lookupproxy#27 |
Member
|
We can test with uisdevops/lookupproxy#26 |
Member
Author
|
True, I just added a new automated build rule for a new branch and was going to push that branch to see, but merging uisdevops/lookupproxy#26 would work just as well. I just worry about merging that because we've got no way to safely test it at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lookupproxy compose configuration was only semi-functional. Since we're going to need to re-deploy the lookupproxy in development anyway to bring in the django-automationoauth fixes, fix up the configuration so that it can use the upstream production image.
This should further reduce CircleCI build times and also means that lookupproxy actually works in development. Previously it didn't since the OAuth2 configuration was not being set.