hotfix - enable CMake to checkout frozen references for physics_mmm and UGWP#231
Closed
guoqing-noaa wants to merge 2 commits intoufs-community:gsl/developfrom
Closed
hotfix - enable CMake to checkout frozen references for physics_mmm and UGWP#231guoqing-noaa wants to merge 2 commits intoufs-community:gsl/developfrom
guoqing-noaa wants to merge 2 commits intoufs-community:gsl/developfrom
Conversation
This was referenced Mar 18, 2026
clark-evans
reviewed
Mar 18, 2026
clark-evans
reviewed
Mar 18, 2026
Collaborator
|
Replaced by #233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in PR #230 ,
CMakealways check out the latest branch ofphysics_mmmandUGWP.Apparently some recent changes in
physics_mmmbreak the CMake build system as reported in #228The expected good solution will be that we use
git submoduleuniversally to manage all MPAS-Model submodules and retire all other nonstandard methods. But it is uncertain when this will happen.Before that, this PR provides a hotfix on
src/core_atmosphere/CMakeLists.txtto enable it to checkout frozen references forphysics_mmmandUGWPso that we can compile MPAS-Model successfully using CMake.Mandatory Questions
Priority Reviewers