Skip to content

hotfix - enable CMake to checkout frozen references for physics_mmm and UGWP#231

Closed
guoqing-noaa wants to merge 2 commits intoufs-community:gsl/developfrom
guoqing-noaa:cmake_hotfix
Closed

hotfix - enable CMake to checkout frozen references for physics_mmm and UGWP#231
guoqing-noaa wants to merge 2 commits intoufs-community:gsl/developfrom
guoqing-noaa:cmake_hotfix

Conversation

@guoqing-noaa
Copy link
Collaborator

@guoqing-noaa guoqing-noaa commented Mar 18, 2026

As discussed in PR #230 , CMake always check out the latest branch of physics_mmm and UGWP.
Apparently some recent changes in physics_mmm break the CMake build system as reported in #228

The expected good solution will be that we use git submodule universally to manage all MPAS-Model submodules and retire all other nonstandard methods. But it is uncertain when this will happen.

Before that, this PR provides a hotfix on src/core_atmosphere/CMakeLists.txt to enable it to checkout frozen references for physics_mmm and UGWP so that we can compile MPAS-Model successfully using CMake.

Mandatory Questions

  • Does this PR include any additions or changes to external inputs (e.g., microphysics lookup tables, static data for gravity-wave drag -- things like that)?
    • no
  • Does this PR require updating one or more baselines for the CI tests? If so, what?
    • no

Priority Reviewers

@guoqing-noaa guoqing-noaa changed the title enable CMake to checkout frozen references for physics_mmm and UGWP hotfix - enable CMake to checkout frozen references for physics_mmm and UGWP Mar 18, 2026
@dustinswales
Copy link
Collaborator

dustinswales commented Mar 20, 2026

Replaced by #233

@guoqing-noaa guoqing-noaa deleted the cmake_hotfix branch March 20, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants