Skip to content

Bugfix and tuning for MYNN-SFC#223

Open
joeolson42 wants to merge 5 commits intoufs-community:gsl/developfrom
joeolson42:mynnsfc_20260309
Open

Bugfix and tuning for MYNN-SFC#223
joeolson42 wants to merge 5 commits intoufs-community:gsl/developfrom
joeolson42:mynnsfc_20260309

Conversation

@joeolson42
Copy link
Collaborator

@joeolson42 joeolson42 commented Mar 11, 2026

This PR updates the surface driver and the pointer to the MYNN-SFC, which includes:

  1. fixes a bug for an uninitialized variable PSIQ10 (in land, ice, and water components)
  2. tuning for config_mynn_sfcflux_land = 1, such that the reduction in Bowen ratio is at least halved over forests while a small reduction in the Bowen ratio is extended to grassland/cropland. Overall, this reduces the impact relative to the original code.
  3. New code was added to the CI tests to check code coverage.
  4. Some code cleanup was add, like removal of unused code.
  5. More robust logic for determining the surface type (land, water, or ice). An update to the CI tests was necessary to accommodate changes to the interface.

Testing was done in single case study (in both MPAS and WRF) and CI tests in MYNN-SFC submodule.

Priority Reviewers

  • Please list the developers/collaborators you'd like to prioritize for review
  • Example:

@clark-evans clark-evans linked an issue Mar 11, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with MYNN-SFC when running intel debug

4 participants