refactor: introduce shared feed helpers#246
Open
spierenburg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR brings
modules/feedutils.pywith shared helpers for common feed-module behavior:abbandakamaiRSS feed modules to use the shared helpers.Why it matters
Many feed modules duplicate the same settings-loading and description-cleaning logic. That makes behavior drift likely and increases the cost of fixing bugs across feeds.
This PR introduces a small shared utility module and migrates two representative feeds as a safe first step. It keeps behavior equivalent while creating a pattern future PRs can apply incrementally to the rest of the RSS modules.
Validation