Open
Conversation
Contributor
|
Why does it have to be the same instance of the manager? |
Member
Author
The counter is bound to the plugin manager instance. |
tfarago
reviewed
May 30, 2025
Contributor
|
If I don't specify the number, it just gives me the first one? |
Contributor
|
I believe the code but would like to talk about this shortly next week if possible. There are some things not clear to me and it will be faster to just discuss them while looking at the code. |
MarcusZuber
force-pushed
the
get_net_camera
branch
from
586cf53 to
9d4140f
Compare
MarcusZuber
force-pushed
the
get_net_camera
branch
from
9d4140f to
39e340b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Together with ufo-kit/uca-net#25, this allows to just create instances of net-camera without taking into account the number of sub-net-camera.
For concert we need to make sure, that always the same plugin_manager is used.