Add a few more user state dirs made by actual user creation in provision user helper#563
Open
jonasbardino wants to merge 1 commit into
Conversation
…tantly expected e.g. during useradm operations like edit_user, delete_user, etc. and therefore difficult to do without when adding test coverage a.o. in #561. Introduce two more common DNs used across tests: Other User and No Such User. Polish a long comment with some typos and incomplete ending.
jonasbardino
added
the
test-only
jonasbardino
added a commit
that referenced
this pull request
May 29, 2026
albu-diku
approved these changes
Jun 4, 2026
Contributor
albu-diku
left a comment
albu-diku
left a comment
There was a problem hiding this comment.
That's a good place to do it I think - just double checked and the last set of changes in the area did unify on the ..._dirs function as I'd remembered.
Two ideas - it might be worth having a constant that lists which keys of users to loop over calling mkdir, the idea would be keep similarity with _USERADM_PATH_KEYS. The second is creating there directories unconditionally means a bunch of ensure_dirs_exist calls in the tests for the corresponding dirs are no longer needed and I wonder if it is worth cleaning those up here as well (mostly to save any confusion in the future).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a few more user state dirs made by actual user creation and importantly expected e.g. during
useradmoperations likeedit_user,delete_user, etc. and therefore difficult to do without when adding test coverage a.o. in #561. Introduce two more common DNs used across tests: Other User and No Such User.Polish a long comment with some typos and incomplete ending.