feat(financial): add chart type and computed message to validation re… - #22
Merged
Merged
Conversation
…sults Introduces a `chartType` field (GL, PPM, INVALID) to financial validation responses to explicitly state the detected chart string type. The `message` field is now a computed property within the `FinancialValidationResult` model, automatically generating the appropriate user-friendly message based on the chart string's validity and type. This ensures consistent messaging directly from the model and simplifies integration for consumers.
srkirkland
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sults
Introduces a
chartTypefield (GL, PPM, INVALID) to financial validation responses to explicitly state the detected chart string type.The
messagefield is now a computed property within theFinancialValidationResultmodel, automatically generating the appropriate user-friendly message based on the chart string's validity and type. This ensures consistent messaging directly from the model and simplifies integration for consumers.