Conversation
Port the downstream Codex runtime safeguards, portable session state, structured outcome handling, retry accounting, and context telemetry onto upstream v1.0.1. Add focused coverage and document the restricted MCP-only security model. Assisted-by: OpenAI Codex Signed-off-by: urd00m <alanlw2@illinois.edu>
Collaborator
Author
|
Don't merge/review yet, will ping when ready. |
Keep the existing restricted MCP-only behavior available through an explicit allow_builtin_tools=False setting, and document the sandbox compatibility boundary.\n\nAssisted-by: OpenAI Codex
Collaborator
Author
|
can merge now, it works in my testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens and extends the Codex model backend for normal and restricted execution. It enables Codex built-in tools by default, retains an explicit MCP-only restricted mode, safely carries filtered Codex session state between Ray workers, records structured terminal and usage telemetry, continues max-output sessions, and retries transient model-capacity failures with capped exponential backoff and jitter.
Compatibility notes:
allow_builtin_tools=Falseto retain the restricted MCP-only mode.tomlito read Codex configuration.Tests:
pytest -q chia/models/tests/test_codex.py— 71 passed, 5 skippedpytest -q chia/models/tests— 350 passed, 132 skippedRelated PRs / Issues:
None.
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?AI assistance disclosure:
AI assistance was used during implementation and review. The contributor accepts responsibility for the complete change.