Skip to content

fix: the delete_viewport endpoint calls check_viewpo... in viewports.py #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: the delete_viewport endpoint calls check_viewpo... in viewports.py #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions api/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,19 +295,20 @@ def check_viewport_owner(request, viewport_name):
"""Check if the current user is admin or owner of the viewport.

Returns (True, None) if authorized, (False, JsonResponse 403) if not.
Viewports without _config.json (legacy) are allowed for anyone.
Viewports without _config.json (legacy) are denied for non-superusers
since ownership cannot be verified.
"""
if request.user.is_superuser:
return True, None
current_user = request.user.username if request.user.is_authenticated else None
config_file = VIEWPORTS_DIR / f'{viewport_name}_config.json'
if not config_file.exists():
return True, None
return False, JsonResponse({'success': False, 'error': 'Permission denied'}, status=403)
try:
with open(config_file) as f:
cfg = json.load(f)
except Exception:
return True, None
return False, JsonResponse({'success': False, 'error': 'Permission denied'}, status=403)
owner = cfg.get('created_by')
if not owner or owner == current_user:
return True, None
Expand Down