Repository navigation
Submission prep: key check, privacy doc, shot list and DEV post - #5
Merged
Merged
Conversation
…the code, shot list and DEV post sections
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting the repo ready for the Presage challenge entry.
Code
npm run smokenow looks for the key the same way the app does (SMARTSPECTRA_API_KEY, then.smartspectra-key). It says where the key was found and never prints it. Before this, the README told you to put the key in the file and run the smoke check, but the script only read the environment variable.scripts/find-key.mjsholds that lookup.test/setup.test.js: the key lookup order,.smartspectra-keybeing git-ignored, and SDK telemetry being off unless the writer ticks the box. 28 tests in total.Docs
PRIVACY.mdnow matches the code more closely. It lists the To and From names and the date as kept, says the reader's host sees an ordinary page request but never the letter, notes that smiles are not requested when turned off, and notes Chromium's spelling dictionary on Windows and Linux.README.md: the smoke step is described correctly, the first start downloads Electron, and the tested platform is stated.docs/shot-list.md: an 80 second shot list for the demo video, with DEV's embed rules.docs/dev-post.md: sections follow the challenge template, with a marked placeholder for the video link. Also includes the earlier post commit fromsubmission-post.No change to app behaviour, the reader page or Vercel settings.