reference count is logged in as undefined, and the channel cannot be GC'ed though#69
Open
reference count is logged in as undefined, and the channel cannot be GC'ed though#69
Conversation
Contributor
Author
Contributor
|
We should never initialize channels of no widget references them, since that's just a waste of both memory and CPU cycles (while garbage collecting them on the next tick). I'm not sure why we do this but if we really have to, we should do a lazy initialization, and only initialize the channel when someone actually needs it (newDataChannel should return a Lazy Promise that should be resolved when someone actually calls then on it). That way, we keep the gc happy, and the memory footprint down. |
Contributor
|
There's an issue for that already in our internal repo, but never got to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some context:
undefined, how is initialized innewDataChannels.time_of_reference_expiryis null when the channel is first createdgc.coffee:channelCanBeGarbageCollected, this piece of code will activate, because thetime_of_reference_expiryis nullso the channel will never have
time_of_reference_expirythus will not advance to return true to GC the channel.