Repository navigation
feat(stovepipe): load older queue requests on scroll - #931
Merged
Merged
Conversation
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
October 23, 2026 20:59
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 23, 2026 20:59
Summary: ## Why? Browsing a long Stovepipe queue currently requires navigating between pages. Load older requests as users scroll, with clear loading feedback that stays stable while batches arrive. ## What? - Append 50-request batches using existing continuation URLs, retaining rows and scroll position across request-detail visits. - Add an authenticated, uncached host endpoint; prevent overlapping loads, duplicate rows, and repeated continuation loops, and offer explicit retry after failures. - Show a delayed, fading BaseUI spinner in a reserved footer so fast loads do not flash and controls stay steady. Respect reduced motion and retain link pagination without JavaScript. - Refresh visible statuses without reordering rows; offer new arrivals through Show latest requests. - Cover scrolling, failures, navigation, authentication, accessibility, narrow layouts, and loading visuals in browser tests. Test Plan: Manually scrolled through 500 seeded requests in ten batches, verifying all IDs appeared once without clicking Load more. Checked the loading indicator on desktop and narrow viewports, stable footer height, reduced motion, and request details with history and project results. For a reproducible real-stack browser run with seeded pagination data, run `./tool/bazel test //web/test/e2e/stovepipe:web_test --test_output=errors` with Docker running. To run the UI locally, use `make local-stovepipe-web-start`, open the printed Web UX URL, and sign in with `test` / `test` (or the configured `STOVEPIPE_WEB_TOKEN`). Ingest more than 50 requests into a queue to exercise scrolling; the regular local stack starts without the browser-test fixtures.
mnoah1
force-pushed
the
mnoah1/stovepipe-infinite-scroll
branch
from
October 23, 2026 21:04
ef67e4a to
d45fa6f
Compare
prathshenoy
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Browsing a long Stovepipe queue currently requires navigating between pages. Load older requests as users scroll, with clear loading feedback that stays stable while batches arrive.
What?
Test Plan
Manually scrolled through 500 seeded requests in ten batches, verifying all IDs appeared once without clicking Load more. Checked the loading indicator on desktop and narrow viewports, stable footer height, reduced motion, and request details with history and project results.
For a reproducible real-stack browser run with seeded pagination data, run
./tool/bazel test //web/test/e2e/stovepipe:web_test --test_output=errorswith Docker running.To run the UI locally, use
make local-stovepipe-web-start, open the printed Web UX URL, and sign in withtest/test(or the configuredSTOVEPIPE_WEB_TOKEN). Ingest more than 50 requests into a queue to exercise scrolling; the regular local stack starts without the browser-test fixtures.