Repository navigation
fix(changeprovider): preserve GitHub HTTP status errors - #806
Merged
behinddwalls merged 2 commits intoOct 7, 2026
Merged
Conversation
Tmwakalasya
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 7, 2026 19:59
behinddwalls
approved these changes
Oct 7, 2026
behinddwalls
enabled auto-merge
October 7, 2026 21:07
behinddwalls
temporarily deployed
to
stack-rebase
October 7, 2026 21:22 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The GitHub change provider formats rejected HTTP responses as plain errors. The orchestrator's existing HTTP classifier cannot recover the status code, so a temporary 503 or 429 during PR metadata retrieval is treated as non-retryable and sent to dead-letter handling.
What?
Return the existing
platform/http.StatusError, wrapped with%wto preserve GitHub API context. Add provider-level regression coverage for status/body preservation and retry classification: 503/429 are retryable dependency failures, while 400/401 remain permanent dependency failures. Update the Bazel dependencies.Test Plan
submitqueue/extension/changeprovider/github,platform/errs/http, andplatform/http.go vet -mod=readonly ./submitqueue/extension/changeprovider/github.make fmt lint check-tidy check-gazelle.Issue
No existing issue. Found while tracing the GitHub provider's error classification.