Repository navigation
feat(stovepipe): expose List RPC - #795
Merged
mnoah1 merged 1 commit intoOct 6, 2026
Merged
Conversation
mnoah1
marked this pull request as ready for review
October 6, 2026 21:59
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 6, 2026 21:59
Summary: Wire the approved List RPC to the controller in #785. Preserve optional time-bound presence, map current request summaries to protobuf, and use the same configured queues as Ingest. Add mapper and handler coverage; end-to-end coverage remains a follow-up. Test Plan: All 22 Stovepipe and service unit targets pass. make fmt gazelle lint check-tidy check-gazelle passes. Revert Plan: Revert this commit to leave List unimplemented again; existing RPCs and storage are unchanged. API Changes: Expose the existing List RPC. No protobuf or schema changes.
mnoah1
force-pushed
the
mnoah1/stovepipe-list-rpc
branch
from
October 6, 2026 21:59
c1d49e7 to
4ab1fe0
Compare
behinddwalls
approved these changes
Oct 6, 2026
DivyanshGarg380
pushed a commit
to DivyanshGarg380/submitqueue
that referenced
this pull request
Oct 7, 2026
## Why? Verify the List RPC added in uber#795 against the real gRPC service and MySQL, while keeping read-contract tests independent of asynchronous ingestion workflows. ## What? ### Added - List coverage for pagination and timestamp ties, time-window defaults and boundaries, queue isolation, unknown acceptance times, and invalid requests/tokens. - Assertions in existing ingest workflows that List exposes lifecycle summaries, deduplication preserves acceptance time, and acceptance time matches request history. - RFC update marking E2E coverage complete. ### Refactored - Move ingest scenarios from `suite_test.go` into `ingest_test.go`; keep setup/teardown and health checks in the suite, List scenarios in `list_test.go`, and reusable helpers in `harness_test.go`. This keeps infrastructure separate from behavior and makes each group easier to review. - Seed List fixtures through storage interfaces on dedicated queues. This makes edge cases deterministic and lets List tests run without relying on ingest tests or pipeline timing. - Remove transient queue-message-count assertions and use durable acknowledged offsets to verify processing. A consumer can acknowledge and garbage-collect a message before a test counts it. No production behavior, API, or schema changes. ## Test Plan - Full Stovepipe E2E suite passed. - List-only scenarios passed twice without running ingest tests. - Stovepipe/service unit tests and repository formatting, lint, tidy, and Gazelle checks passed. - Internal validator lint/coverage checks could not complete in this OSS workspace; coverage requires a missing `.arcconfig`. ## Revert Plan Revert this test and documentation change; runtime behavior is unchanged.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Listhandler to route to the new List controller. Wire this into the existing OSS service.Test Plan
All 22 Stovepipe and service unit targets pass. make fmt gazelle lint check-tidy check-gazelle passes.
Revert Plan
Revert this commit to leave List unimplemented again; existing RPCs and storage are unchanged.
API Changes
Expose the existing List RPC. No protobuf or schema changes.