Repository navigation
feat(agent): add actionable autoreview skill - #753
Merged
Merged
Conversation
## Summary ### Why? SubmitQueue changes need a repeatable review workflow that checks repository invariants from independent perspectives without promoting style preferences into merge-blocking feedback. ### What? Adds a tool-agnostic autoreview skill under `.agents/skills/` with scoped mechanical checks, independent architecture, correctness, simplicity, testing, operability, and documentation lenses, plus an evidence gate that requires impact, a bounded fix, and verification for every material finding. Adds a Bazel-managed Python scope tool and tests for exact Git ranges, changed-file classification, affected packages, mock sources, candidate smells, and hermetic tooling rules. Claude Code discovers the same skill through a checked-in symlink. ## Test Plan - ✅ `./tool/bazel test //.agents/skills/autoreview/scripts:review-scope-test --test_output=errors` - ✅ `./tool/bazel build //.agents/skills/autoreview/...` - ✅ `./tool/bazel mod tidy` - ✅ `git diff --check`
behinddwalls
force-pushed
the
preetam/add-skills
branch
from
September 28, 2026 22:59
f467701 to
718b120
Compare
behinddwalls
marked this pull request as ready for review
September 28, 2026 22:59
## Summary ### Why? Gazelle enforces canonical attribute ordering and the Tidy CI job rejected the manually ordered Python test target. ### What? Moves the test size attribute to Gazelle's generated position so regeneration leaves the BUILD file unchanged. ## Test Plan - ✅ `make gazelle`
mnoah1
approved these changes
Sep 28, 2026
behinddwalls
temporarily deployed
to
stack-rebase
September 28, 2026 23:20 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SubmitQueue changes need a repeatable review workflow that checks repository invariants from independent perspectives without promoting style preferences into merge-blocking feedback.
What?
Adds a tool-agnostic autoreview skill under
.agents/skills/with scoped mechanical checks, independent architecture, correctness, simplicity, testing, operability, and documentation lenses, plus an evidence gate that requires impact, a bounded fix, and verification for every material finding.Adds a Bazel-managed Python scope tool and tests for exact Git ranges, changed-file classification, affected packages, mock sources, candidate smells, and hermetic tooling rules. Claude Code discovers the same skill through a checked-in symlink.
Test Plan
make check-gazellemake check-tidy./tool/bazel test //.agents/skills/autoreview/scripts:review-scope-test --test_output=errors./tool/bazel build //.agents/skills/autoreview/...git diff --check