Skip to content

feat(agent): add actionable autoreview skill - #753

Merged
behinddwalls merged 3 commits into
mainfrom
preetam/add-skills
Sep 28, 2026
Merged

behinddwalls merged 3 commits into
mainfrom
preetam/add-skills

Conversation

@behinddwalls

@behinddwalls behinddwalls commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Why?

SubmitQueue changes need a repeatable review workflow that checks repository invariants from independent perspectives without promoting style preferences into merge-blocking feedback.

What?

Adds a tool-agnostic autoreview skill under .agents/skills/ with scoped mechanical checks, independent architecture, correctness, simplicity, testing, operability, and documentation lenses, plus an evidence gate that requires impact, a bounded fix, and verification for every material finding.

Adds a Bazel-managed Python scope tool and tests for exact Git ranges, changed-file classification, affected packages, mock sources, candidate smells, and hermetic tooling rules. Claude Code discovers the same skill through a checked-in symlink.

Test Plan

  • ✅ make check-gazelle
  • ✅ make check-tidy
  • ✅ ./tool/bazel test //.agents/skills/autoreview/scripts:review-scope-test --test_output=errors
  • ✅ ./tool/bazel build //.agents/skills/autoreview/...
  • ✅ git diff --check

## Summary

### Why?

SubmitQueue changes need a repeatable review workflow that checks repository invariants from independent perspectives without promoting style preferences into merge-blocking feedback.

### What?

Adds a tool-agnostic autoreview skill under `.agents/skills/` with scoped mechanical checks, independent architecture, correctness, simplicity, testing, operability, and documentation lenses, plus an evidence gate that requires impact, a bounded fix, and verification for every material finding.

Adds a Bazel-managed Python scope tool and tests for exact Git ranges, changed-file classification, affected packages, mock sources, candidate smells, and hermetic tooling rules. Claude Code discovers the same skill through a checked-in symlink.

## Test Plan

- ✅ `./tool/bazel test //.agents/skills/autoreview/scripts:review-scope-test --test_output=errors`
- ✅ `./tool/bazel build //.agents/skills/autoreview/...`
- ✅ `./tool/bazel mod tidy`
- ✅ `git diff --check`
@behinddwalls
behinddwalls marked this pull request as ready for review September 28, 2026 22:59
@behinddwalls
behinddwalls requested review from a team and sbalabanov as code owners September 28, 2026 22:59
behinddwalls and others added 2 commits September 28, 2026 16:03
## Summary

### Why?

Gazelle enforces canonical attribute ordering and the Tidy CI job rejected the manually ordered Python test target.

### What?

Moves the test size attribute to Gazelle's generated position so regeneration leaves the BUILD file unchanged.

## Test Plan

- ✅ `make gazelle`
@behinddwalls
behinddwalls added this pull request to the merge queue Sep 28, 2026
Merged via the queue into main with commit 6916596 Sep 28, 2026
16 checks passed
@behinddwalls
behinddwalls deleted the preetam/add-skills branch September 28, 2026 23:20

This branch was previously deployed

1 inactive deployment
stack-rebase — fb86f69f Deployed Sep 28, 2026 by behinddwalls via Rebase Stack #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants