Repository navigation
fix(submitqueue): preserve conclude dead-letter outcomes - #1041
Draft
sbalabanov wants to merge 1 commit into
Draft
sbalabanov wants to merge 1 commit into
sbalabanov wants to merge 1 commit into
Conversation
Summary: Share primary conclusion's terminal member reconciliation with a dedicated conclude final handler. Preserve the batch outcome, repair terminal membership, and retain non-terminal, missing, malformed, or partially completed work. Test Plan: TestConcludeFinalBinding runs the actual pipeline final consumer and verifies log replay on success and Nack retention of incomplete obligations. TestDLQConcludeController_TerminalOutcomes checks all three outcome mappings; TestDLQConcludeController_ReplaysPartialFanout proves persisted diagnostics survive a member log failure and replay without overwriting another winner. Revert Plan: Pause conclude final processing before reverting. Retain final queue records and request logs; do not reinterpret stored terminal outcomes as failures.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share primary conclusion's terminal member reconciliation with a dedicated
conclude final handler. Preserve the batch outcome, repair terminal membership,
and retain non-terminal, missing, malformed, or partially completed work.
Repro
Test Plan
TestConcludeFinalBinding runs the actual pipeline final consumer and verifies
log replay on success and Nack retention of incomplete obligations.
TestDLQConcludeController_TerminalOutcomes checks all three outcome mappings;
TestDLQConcludeController_ReplaysPartialFanout proves persisted diagnostics
survive a member log failure and replay without overwriting another winner.
Revert Plan
Pause conclude final processing before reverting. Retain final queue records
and request logs; do not reinterpret stored terminal outcomes as failures.
Issues