Skip to content

feat(stovepipe): store fixer submissions per issue and backend - #1032

Open
mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/stovepipe-repair-state
Open

mnoah1 wants to merge 1 commit into
mainfrom
mnoah1/stovepipe-repair-state

Conversation

@mnoah1

@mnoah1 mnoah1 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Why?

The existing fixer flow stores one fix ID on a build issue. That cannot independently track several backends repairing the same issue opening, or retain backend metadata before a submission is accepted. Extending the fixer to multiple issues and backends needs durable state for each issue/backend pair.

What?

Add an IssueRepair record and queue-scoped store keyed by issue opening and executor ID, with a MySQL schema, generated mocks, and storage tests. Each row retains an accepted fix ID or terminal skip reason, executor-owned map[string]string metadata, and a version for conditional updates. Empty fix ID and skip reason mean the submission is pending.

This PR provides the storage foundation while preserving existing dispatch behavior. #1034 extends the fixer API, and #1033 uses these records to dispatch independently to each backend.

Test Plan

./tool/bazel test //stovepipe/extension/storage/mysql:go_default_test //service/stovepipe/server:go_default_test --test_output=errors exercises pending creation, metadata round trips, accepted/skipped updates, stale-version rejection, and existing service wiring. Local lint, module-tidy, and Gazelle checks also completed.

Revert Plan

Revert dependent dispatcher changes first, then revert this PR. The additive table can remain.

Issue Links

No issue was provided. Persistence foundation for #1034, #1033, and #1035.

Stack

  1. @ feat(stovepipe): store fixer submissions per issue and backend #1032
  2. feat(stovepipe): extend fixer API for batching and multiple backends #1034
  3. feat(stovepipe): offer newly opened issues to every registered fixer #1033
  4. feat(stovepipe): extend fixer DLQ recovery to every issue and backend #1035

@mnoah1
mnoah1 added this pull request to stack #1038 November 6, 2026 22:26
@mnoah1 mnoah1 changed the title feat(stovepipe): persist versioned repair submission state feat(stovepipe): store fixer submissions per issue and backend Nov 6, 2026
@mnoah1
mnoah1 marked this pull request as ready for review November 6, 2026 22:31
@mnoah1
mnoah1 requested review from a team, behinddwalls and sbalabanov as code owners November 6, 2026 22:31

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant