Skip to content

Add additonal mapper for scip symbol kind to protocol symbol#49

Merged
shuklahy merged 3 commits intouber:mainfrom
shuklahy:hshukla/mapper
Feb 24, 2026
Merged

Add additonal mapper for scip symbol kind to protocol symbol#49
shuklahy merged 3 commits intouber:mainfrom
shuklahy:hshukla/mapper

Conversation

@shuklahy
Copy link
Copy Markdown
Collaborator

Description

We observed that the abstract method are not correctly identified in scip lsp
despite the type was correctly produced by indexer.

This was due to missing mapping for the types supported which resulted into null type being sent out.

Here in this change we add missing types in the mapper.
This would ensure we are able to correctly identify the types in the lsp client.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...)
  • I have tested this manually with a real project

Manual Testing Details

Describe how you tested these changes:

  • IDE used for testing:
  • Project(s) tested against:
  • Specific features/scenarios verified:

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

@shuklahy shuklahy changed the title Add mapper for symbol kind to document symbol Add additonal mapper for scip symbol kind to protocol symbol Feb 24, 2026
@shuklahy shuklahy merged commit d010edc into uber:main Feb 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants