Closed
Conversation
Left over from uber#19
This PR fixed some bugs in the logic of scip: - Refactored SCIP configuration selection to consistently support monorepo-specific config with _default fallback, and - clarified the corresponding log messages. - Fixed default index directory selection in createNewScipRegistry so _default SCIP directories are applied correctly when present. - Fixed a watcher log formatting issue (%d → %q) for workspace root. - Resolved a unit test panic caused by Go “typed nil” interfaces by adding a robust nil-check helper for registry.Registry and using it when creating registries. - Addressed a potential nil dereference in hover() by avoiding writes to a nil *protocol.Hover result pointer. - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update - [ ] Refactoring (no functional changes) - [ ] Performance improvement - [ ] Test improvement - [x] Language Server (ULSP) - [ ] SCIP Generation (Python utilities) - [ ] VS Code/Cursor Extension - [ ] Java Aggregator - [ ] Build System (Bazel) - [ ] Documentation - [ ] Tests - [x] I have added tests that prove my fix is effective or that my feature works - [x] New and existing unit tests pass locally with my changes (`bazel test //...`) - [x] I have tested this manually with a real project Describe how you tested these changes: - IDE used for testing: - Project(s) tested against: - Specific features/scenarios verified: - [x] My code follows the existing code style and conventions - [x] I have performed a self-review of my own code - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have made corresponding changes to the documentation - [ ] I have updated BUILD.bazel files if I added new source files - [x] My changes generate no new warnings - [x] Any dependent changes have been merged and published Include any relevant screenshots, logs, or output that demonstrates the changes. Fixes #(issue number) Closes #(issue number) Related to #(issue number) Any additional information that reviewers should know about this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes made in this PR.
Type of Change
Component(s) Affected
Testing
bazel test //...)Manual Testing Details
Describe how you tested these changes:
Checklist
Screenshots/Logs (if applicable)
Include any relevant screenshots, logs, or output that demonstrates the changes.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Additional Notes
Any additional information that reviewers should know about this PR.