Skip to content

Fix some bugs in reading configs#43

Merged
zerunz merged 2 commits intouber:mainfrom
zerunz:zerunz/config
Jan 15, 2026
Merged

Fix some bugs in reading configs#43
zerunz merged 2 commits intouber:mainfrom
zerunz:zerunz/config

Conversation

@zerunz
Copy link
Copy Markdown
Collaborator

@zerunz zerunz commented Jan 15, 2026

Description

This PR fixed some bugs in the logic of scip:

  • Refactored SCIP configuration selection to consistently support monorepo-specific config with _default fallback, and - clarified the corresponding log messages.
  • Fixed default index directory selection in createNewScipRegistry so _default SCIP directories are applied correctly when present.
  • Fixed a watcher log formatting issue (%d → %q) for workspace root.
  • Resolved a unit test panic caused by Go “typed nil” interfaces by adding a robust nil-check helper for registry.Registry and using it when creating registries.
  • Addressed a potential nil dereference in hover() by avoiding writes to a nil *protocol.Hover result pointer.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test improvement

Component(s) Affected

  • Language Server (ULSP)
  • SCIP Generation (Python utilities)
  • VS Code/Cursor Extension
  • Java Aggregator
  • Build System (Bazel)
  • Documentation
  • Tests

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (bazel test //...)
  • I have tested this manually with a real project

Manual Testing Details

Describe how you tested these changes:

  • IDE used for testing:
  • Project(s) tested against:
  • Specific features/scenarios verified:

Checklist

  • My code follows the existing code style and conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have updated BUILD.bazel files if I added new source files
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots/Logs (if applicable)

Include any relevant screenshots, logs, or output that demonstrates the changes.

Related Issues

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Additional Notes

Any additional information that reviewers should know about this PR.

Comment thread src/ulsp/controller/scip/scip.go Outdated
@zerunz zerunz merged commit bb070f3 into uber:main Jan 15, 2026
4 checks passed
zerunz added a commit to zerunz/scip-lsp that referenced this pull request Jan 16, 2026
This PR fixed some bugs in the logic of scip:
- Refactored SCIP configuration selection to consistently support
monorepo-specific config with _default fallback, and - clarified the
corresponding log messages.
- Fixed default index directory selection in createNewScipRegistry so
_default SCIP directories are applied correctly when present.
- Fixed a watcher log formatting issue (%d → %q) for workspace root.
- Resolved a unit test panic caused by Go “typed nil” interfaces by
adding a robust nil-check helper for registry.Registry and using it when
creating registries.
- Addressed a potential nil dereference in hover() by avoiding writes to
a nil *protocol.Hover result pointer.

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Documentation update
- [ ] Refactoring (no functional changes)
- [ ] Performance improvement
- [ ] Test improvement

- [x] Language Server (ULSP)
- [ ] SCIP Generation (Python utilities)
- [ ] VS Code/Cursor Extension
- [ ] Java Aggregator
- [ ] Build System (Bazel)
- [ ] Documentation
- [ ] Tests

- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] New and existing unit tests pass locally with my changes (`bazel
test //...`)
- [x] I have tested this manually with a real project

Describe how you tested these changes:
- IDE used for testing:
- Project(s) tested against:
- Specific features/scenarios verified:

- [x] My code follows the existing code style and conventions
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [ ] I have updated BUILD.bazel files if I added new source files
- [x] My changes generate no new warnings
- [x] Any dependent changes have been merged and published

Include any relevant screenshots, logs, or output that demonstrates the
changes.

Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)

Any additional information that reviewers should know about this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants