refactor(lib/metainfogen): deduplicate metainfo generation - #651
Draft
Pybsama wants to merge 1 commit into
Draft
Conversation
Move cache-file metainfo generation and persistence into CAStore so both cache writes and metainfogen use one implementation. Add focused coverage for successful persistence and error paths.
|
|
thijmv
reviewed
Aug 6, 2026
| return metaInfo, nil | ||
| } | ||
|
|
||
| func (s *CAStore) generateMetadataFromFile(name string, pieceLength int64) error { |
Collaborator
There was a problem hiding this comment.
Did you consider making this function public and calling it directly from Generator.generate after computing the piece length? That would avoid having to introduce an additional helper function to the ca store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAStore.GenerateCacheFileMetaInfooperation for opening a cached blob, generating torrent metainfo, and persisting itmetainfogen.Generator, while keeping piece-length selection inmetainfogenThis keeps the existing error prefixes and metadata overwrite behavior while removing the duplicate workflow introduced with the in-memory cache path.
Fixes #488.
Test plan
CGO_CFLAGS="-Wno-return-local-addr" go test -count=1 -race ./lib/store ./lib/metainfogenCGO_CFLAGS="-Wno-return-local-addr" go test $(go list ./...) -coverCGO_CFLAGS="-Wno-return-local-addr" go build ./...golangci-lint run ./...CGO_CFLAGS="-Wno-return-local-addr" go vet ./lib/store ./lib/metainfogenCGO_CFLAGS="-Wno-return-local-addr" go test ./lib/store ./lib/metainfogen -bench=. -benchmem -run='^$'