Bump minimum Go version to be 1.25#406
Merged
Merged
Conversation
sonalmahajan15
approved these changes
Feb 24, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 87.21% 87.25% +0.04%
==========================================
Files 72 72
Lines 8312 8312
==========================================
+ Hits 7249 7253 +4
Misses 869 869
+ Partials 194 190 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
260a873 to
16880e3
Compare
sonalmahajan15
approved these changes
May 14, 2026
Golden TestWarning ❌ NilAway errors reported on stdlib are different 📉. 2570 errors on base branch (main, 183b935) Diffs+ /opt/hostedtoolcache/go/1.25.9/x64/src/image/color/ycbcr.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: INTERNAL PANIC: runtime error: invalid memory address or nil pointer dereference
+ goroutine 113049 [running]:
+ runtime/debug.Stack()
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc.func1()
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:440 +0x5d
+ panic({0x8849c0?, 0xc83e30?})
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/panic.go:783 +0x132
+ go.uber.org/nilaway/assertion/function/preprocess.copyGraph(0x0)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:118 +0xac
+ go.uber.org/nilaway/assertion/function/preprocess.(*Preprocessor).CFG(0xc10ca07cd8, 0x0?, 0xc0008907b0)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:49 +0x2a
+ go.uber.org/nilaway/assertion/function/assertiontree.BackpropAcrossFunc({0x9c0a28, 0xc1093bcb40}, 0xc10a96a6e8, 0xc0008907b0, {0xc0008907b0, 0x0, 0xc10a96a6e8, 0xc10be5cf00, 0xc10be5ced0, 0xc10be5c9c0, ...}, ...)
+ /home/runner/work/nilaway/nilaway/assertion/function/assertiontree/backprop.go:911 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc({0x9c0a28?, 0xc1093bcb40?}, 0xc10a96a6e8, 0xc0008907b0, {0xc0008907b0, 0x0, 0xc10a96a6e8, 0xc10be5cf00, 0xc10be5ced0, 0xc10be5c9c0, ...}, ...)
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:446 +0xdd
+ go.uber.org/nilaway/assertion/function.run.func2()
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:194 +0x65
+ sync.(*WaitGroup).Go.func1()
+ /opt/hostedtoolcache/go/1.25.9/x64/src/sync/waitgroup.go:239 +0x4a
+ created by sync.(*WaitGroup).Go in goroutine 62864
+ /opt/hostedtoolcache/go/1.25.9/x64/src/sync/waitgroup.go:237 +0x73
+ /opt/hostedtoolcache/go/1.25.9/x64/src/image/color/ycbcr.go:1:1: INTERNAL ERROR(s):
+ nilaway_assertion_analyzer: nilaway_function_analyzer: INTERNAL PANIC: runtime error: invalid memory address or nil pointer dereference
+ goroutine 184700 [running]:
+ runtime/debug.Stack()
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc.func1()
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:440 +0x5d
+ panic({0x8849c0?, 0xc83e30?})
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/panic.go:783 +0x132
+ go.uber.org/nilaway/assertion/function/preprocess.copyGraph(0x0)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:118 +0xac
+ go.uber.org/nilaway/assertion/function/preprocess.(*Preprocessor).CFG(0xc0b9ec5cd8, 0x18?, 0xc0055f8d80)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:49 +0x2a
+ go.uber.org/nilaway/assertion/function/assertiontree.BackpropAcrossFunc({0x9c0a28, 0xc1deac2d20}, 0xc14e5c8ab8, 0xc0055f8d80, {0xc0055f8d80, 0x0, 0xc14e5c8ab8, 0xc1decba6f0, 0xc1decba6c0, 0xc1deabf6b0, ...}, ...)
+ /home/runner/work/nilaway/nilaway/assertion/function/assertiontree/backprop.go:911 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc({0x9c0a28?, 0xc1deac2d20?}, 0xc14e5c8ab8, 0xc0055f8d80, {0xc0055f8d80, 0x0, 0xc14e5c8ab8, 0xc1decba6f0, 0xc1decba6c0, 0xc1deabf6b0, ...}, ...)
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:446 +0xdd
+ go.uber.org/nilaway/assertion/function.run.func2()
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:194 +0x65
+ sync.(*WaitGroup).Go.func1()
+ /opt/hostedtoolcache/go/1.25.9/x64/src/sync/waitgroup.go:239 +0x4a
+ created by sync.(*WaitGroup).Go in goroutine 96855
+ /opt/hostedtoolcache/go/1.25.9/x64/src/sync/waitgroup.go:237 +0x73
+
+ INTERNAL PANIC: runtime error: invalid memory address or nil pointer dereference
+ goroutine 184724 [running]:
+ runtime/debug.Stack()
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/debug/stack.go:26 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc.func1()
+ /home/runner/work/nilaway/nilaway/assertion/function/analyzer.go:440 +0x5d
+ panic({0x8849c0?, 0xc83e30?})
+ /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/panic.go:783 +0x132
+ go.uber.org/nilaway/assertion/function/preprocess.copyGraph(0x0)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:118 +0xac
+ go.uber.org/nilaway/assertion/function/preprocess.(*Preprocessor).CFG(0xc0b9ec5cd8, 0x18?, 0xc00568d9b0)
+ /home/runner/work/nilaway/nilaway/assertion/function/preprocess/cfg.go:49 +0x2a
+ go.uber.org/nilaway/assertion/function/assertiontree.BackpropAcrossFunc({0x9c0a28, 0xc1deac2d20}, 0xc14e5c8ab8, 0xc00568d9b0, {0xc00568d9b0, 0x0, 0xc14e5c8ab8, 0xc1decbaff0, 0xc1decbafc0, 0xc1deabf6b0, ...}, ...)
+ /home/runner/work/nilaway/nilaway/assertion/function/assertiontree/backprop.go:911 +0x5e
+ go.uber.org/nilaway/assertion/function.analyzeFunc({0x9c0a28?, 0xc1deac2d20?}, 0xc14e5c8ab8, 0xc00568d9b0, {0xc00568d9b0,
...(truncated)...
t(s):
- - `t.ArrayType()` to `a` at runtime/type.go:221:3
-
- (Same nil source could also cause potential nil panic(s) at 3 other place(s): "runtime/type.go:225:8", "runtime/type.go:228:8", and "runtime/type.go:229:28".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/type.go:236:21: Potential nil panic detected. Observed nil flow from source to dereference point:
- - abi/type.go:404:10: literal `nil` returned from `StructType()` in position 0
- - runtime/type.go:236:21: result 0 of `StructType()` accessed field `Fields` via the assignment(s):
- - `t.StructType()` to `s` at runtime/type.go:234:3
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/type.go:457:22: Potential nil panic detected. Observed nil flow from source to dereference point:
- - runtime/type.go:457:22: deep read from field `typemap` lacking guarding; accessed field `Hash` via the assignment(s):
- - `prev.typemap[...]` to `t` at runtime/type.go:454:5
-
- (Same nil source could also cause potential nil panic(s) at 1 other place(s): "runtime/type.go:463:13".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/type.go:525:10: Potential nil panic detected. Observed nil flow from source to dereference point:
- - runtime/type.go:333:10: literal `nil` returned from `resolveTypeOff()` in position 0
- - runtime/type.go:602:19: result 0 of `resolveTypeOff()` passed as arg `t` to `typesEqual()` via the assignment(s):
- - `resolveTypeOff(...)` to `tityp` at runtime/type.go:600:4
- - runtime/type.go:525:10: function parameter `t` accessed field `Kind_`
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/type.go:526:13: Potential nil panic detected. Observed nil flow from source to dereference point:
- - runtime/type.go:333:10: literal `nil` returned from `resolveTypeOff()` in position 0
- - runtime/type.go:602:26: result 0 of `resolveTypeOff()` passed as arg `v` to `typesEqual()` via the assignment(s):
- - `resolveTypeOff(...)` to `vityp` at runtime/type.go:601:4
- - runtime/type.go:526:13: function parameter `v` accessed field `Kind_`
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/utf8.go:108:3: Potential nil panic detected. Observed nil flow from source to dereference point:
- - runtime/string.go:270:23: unassigned variable `dum` passed as arg `p` to `encoderune()`
- - runtime/utf8.go:108:3: function parameter `p` sliced into
-
- (Same nil source could also cause potential nil panic(s) at 12 other place(s): "runtime/utf8.go:111:7", "runtime/utf8.go:112:3", "runtime/utf8.go:113:3", "runtime/utf8.go:119:7", "runtime/utf8.go:120:3", "runtime/utf8.go:121:3", "runtime/utf8.go:122:3", "runtime/utf8.go:125:7", "runtime/utf8.go:126:3", "runtime/utf8.go:127:3", "runtime/utf8.go:128:3", and "runtime/utf8.go:129:3".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/runtime/vdso_linux.go:180:17: Potential nil panic detected. Observed nil flow from source to dereference point:
- - runtime/vdso_linux.go:180:17: unassigned variable `hash` sliced into
-
- (Same nil source could also cause potential nil panic(s) at 1 other place(s): "runtime/vdso_linux.go:181:16".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/unique/canonmap.go:32:12: Potential nil panic detected. Observed nil flow from source to dereference point:
- - abi/type.go:412:10: literal `nil` returned from `MapType()` in position 0
- - unique/canonmap.go:32:12: result 0 of `MapType()` accessed field `Hasher` via the assignment(s):
- - `abi.TypeOf(m).MapType()` to `mapType` at unique/canonmap.go:31:2
- /opt/hostedtoolcache/go/1.25.9/x64/src/unique/canonmap.go:32:12: Potential nil panic detected. Observed nil flow from source to dereference point:
- - abi/type.go:412:10: literal `nil` returned from `MapType()` in position 0
- - unique/canonmap.go:32:12: result 0 of `MapType()` accessed field `Hasher` via the assignment(s):
- - `abi.TypeOf(m).MapType()` to `mapType` at unique/canonmap.go:31:2
-
- (Same nil source could also cause potential nil panic(s) at 1 other place(s): "unique/canonmap_test.go:174:12".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/unique/clone.go:58:17: Potential nil panic detected. Observed nil flow from source to dereference point:
- - abi/type.go:404:10: literal `nil` returned from `StructType()` in position 0
- - unique/clone.go:58:17: result 0 of `StructType()` accessed field `Fields` via the assignment(s):
- - `typ.StructType()` to `styp` at unique/clone.go:57:2
-
- (Same nil source could also cause potential nil panic(s) at 1 other place(s): "unique/clone.go:59:9".)
- /opt/hostedtoolcache/go/1.25.9/x64/src/unique/clone.go:74:10: Potential nil panic detected. Observed nil flow from source to dereference point:
- - abi/type.go:420:10: literal `nil` returned from `ArrayType()` in position 0
- - unique/clone.go:74:10: result 0 of `ArrayType()` accessed field `Elem` via the assignment(s):
- - `typ.ArrayType()` to `atyp` at unique/clone.go:73:2
-
- (Same nil source could also cause potential nil panic(s) at 1 other place(s): "unique/clone.go:76:12".) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that Go 1.26 is released, we follow our own version policy and bump the minimum Go version to be 1.25
We also bump the dependencies we use and update the code to leverage the new language features introduced in 1.25