Repository navigation
Optimize V8 return values using POD Set overloads - #1341
Merged
Merged
Conversation
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
Co-authored-by: uNetworkingAB <110806833+uNetworkingAB@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The V8 bindings were using heavy heap-allocated wrapper objects (such as
v8::Boolean,v8::Integer, andv8::Number) when returning primitive values to JavaScript. This pull request replaces these wrapped returns with direct V8 POD (Plain Old Data)Setoverloads, improving execution performance and reducing heap allocation overhead.Refactored Bindings
WebSocket Bindings (
src/WebSocketWrapper.h)Boolean::New(isolate, success)with direct boolean returns.Integer::NewFromUnsigned(isolate, port)with direct uint32_t returns for port, buffered amount, and send status.HTTP Response Bindings (
src/HttpResponseWrapper.h)Boolean::Newwith direct boolean returns in write responses.Integer::NewFromUnsignedandNumber::Newwrapper objects for port and write offsets.App Bindings (
src/AppWrapper.h)Addon Utilities (
src/addon.cpp)Code Pattern Example
Before:
After: