Repository navigation
Skip the first write when a string has more characters than free pool bytes - #1337
Merged
uNetworkingAB merged 1 commit intoSep 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a string has more characters than the free bytes of the pool, it can never fit: the first write from #1335 fills the pool and is thrown away, then the string is measured and written again. Now the first write is skipped. This is the slow path that ValoChet found in #1302.
app.publish('t', message)with no subscribers, Windows, Node 26, min of 9 rounds:€(600 KB of utf-8): from 838 to 672 ustests/strings.jscovers this path with the "past the pool" cases.