Repository navigation
Keep the onAborted capture in MoveOnlyFunction inline storage - #1331
Merged
uNetworkingAB merged 1 commit intoSep 28, 2026
Merged
Conversation
nigrosimone
marked this pull request as ready for review
September 28, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #1325 and #1330.
After #1330 the
onAbortedlambda capturesresand the isolate, 16 bytes, butUniquePersistenthas no noexcept move, so MoveOnlyFunction still puts it on the heap on every call. CapturingresasNoexceptPersistent, likeonDataandonWritabledo since #1325, keeps it inline.Measured on master, Node 26 win-x64, min of 7 alternating runs:
res.onAbortedfrom 80 ns to 45 ns per call. Same behaviour on both builds: only the last callback fires,resthrows after the abort, the callback survives a gc, and 2000 of 2000resobjects are collected afterend.