Skip to content

Fix launcher remaining visible during Text/OCR capture - #80

Open
Ret2Hell wants to merge 1 commit into
typecraft-dev:mainfrom
Ret2Hell:fix/hide-launcher-before-ocr
Open

Ret2Hell wants to merge 1 commit into
typecraft-dev:mainfrom
Ret2Hell:fix/hide-launcher-before-ocr

Conversation

@Ret2Hell

@Ret2Hell Ret2Hell commented Nov 5, 2026

Copy link
Copy Markdown

Summary

Fixes #79.

Starting Text (Trigger → Capture) from omacast could freeze the launcher into the OCR selection screen. The same command works correctly from Omarchy's native menu.

This addresses two parts of the capture hand-off:

  • Dismiss the launcher before executing an Omarchy action, matching the stock menu's ordering. The backend uses a dismissal callback wired to root.hide(), so UI and IPC actions share the same path.
  • Disable compositor fades for the omacast layer with a runtime Hyprland rule, like Omarchy's native overlays. Reapply the rule after configreloaded so an unmapped launcher cannot linger in a capture.

No user Hyprland configuration or keybindings are edited. Existing command strings and native shell-summon routing are preserved.

Relationship to #14

The no-animation rule follows the approach proposed in #14, adapted to the current omacast namespace and repo layout. This PR additionally changes action ordering to dismiss before command execution and adds regression coverage. There is overlap with #14; happy to coordinate rather than duplicate that work.

Testing

  • node --test tests/*.test.js: 146 passed, 2 skipped, 0 failed.
  • New regression tests cover dismissal before OCR/screenshot/custom commands, shell-summon routing, a backend without a dismissal hook, and layer-rule application on startup/config reload.
  • omarchy plugin validate .: passed.
  • git diff --check: passed.
  • Installed and reloaded the branch locally; plugin IPC and backend health checks passed.
  • Verified the runtime layer rule is accepted by the installed Hyprland.
  • Manually tested Text/OCR on Omarchy 4.5.0-3, Hyprland 0.56.2: the launcher disappears and capture works correctly (confirmed by the issue reporter).
  • Compared checksums of user Hyprland configuration files before and after installation: unchanged.

Reapplication on configreloaded is covered by the automated handler test; OCR after a config reload was not separately tested live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launcher remains visible when starting Text/OCR capture

1 participant