Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #79.
Starting Text (Trigger → Capture) from omacast could freeze the launcher into the OCR selection screen. The same command works correctly from Omarchy's native menu.
This addresses two parts of the capture hand-off:
root.hide(), so UI and IPC actions share the same path.omacastlayer with a runtime Hyprland rule, like Omarchy's native overlays. Reapply the rule afterconfigreloadedso an unmapped launcher cannot linger in a capture.No user Hyprland configuration or keybindings are edited. Existing command strings and native shell-summon routing are preserved.
Relationship to #14
The no-animation rule follows the approach proposed in #14, adapted to the current
omacastnamespace and repo layout. This PR additionally changes action ordering to dismiss before command execution and adds regression coverage. There is overlap with #14; happy to coordinate rather than duplicate that work.Testing
node --test tests/*.test.js: 146 passed, 2 skipped, 0 failed.omarchy plugin validate .: passed.git diff --check: passed.Reapplication on
configreloadedis covered by the automated handler test; OCR after a config reload was not separately tested live.