PHP 8.5 - #9
Merged
Merged
PHP 8.5#9
Conversation
- Bump PHP requirement from ^8.2 to ^8.5 in composer.json and CI - Upgrade dev tooling: Pest 2 -> 4, PHPStan 1 -> 2, PHPCS 3 -> 4, PHPMD 2.15 - Replace removed PHPStan 1.x config options with the missingType.iterableValue ignore identifier - Add property/param types and guards to satisfy PHPStan 2 at level max - Point phpunit.xml schema at the installed PHPUnit version - Update workflow: checkout@v5, PHP 8.5, drop removed --no-suggest flag https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT
PHPMD flagged parseRoute() at the cyclomatic complexity threshold of 10 after the handler type guard was added; moving the dynamic key search into a helper brings it back under the limit. https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT
tests/tmp/ is gitignored but routesV2.php was committed before the rule existed, so it stayed tracked. https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT
The .phpunit.cache/ entry was appended onto the tests/tmp/ line, breaking both ignore rules. https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT
It was re-added while the .gitignore rule was broken. https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Supersedes #2 — includes all of its
feature/php82work, then bumps the target from PHP 8.2 to PHP 8.5.composer.json:php ^8.2→^8.5actions/checkoutv3 → v5, dropped removed--no-suggestcomposer flagcomposer.lockregeneratedFollow-on fixes required by the new tooling
phpstan.neon.dist: replaced options removed in PHPStan 2 (checkMissingIterableValueType,inferPrivatePropertyTypeFromConstructor) with themissingType.iterableValueignore identifierRouteMatch::$handler, precise return shape + handler type guard inRouter::parseRoute(), typedcachedRouter()options array, guard on the included route-cache fileRouter::findDynamicKey()to keepparseRoute()under PHPMD's cyclomatic complexity thresholdphpunit.xmlschema now tracks the installed PHPUnit versionTesting
https://claude.ai/code/session_01AHKGsXJZFz9XSLcJDJtdDT