Repository navigation
Let a latest install pin through the 1.0 tag - #409
Merged
Merged
Conversation
ARBITER_VERSION=latest does not match the numeric pin rewrite, and required=False only ignored a missing file. That aborted the 1.0.0 tag after CMakeLists and the changelog were already at 1.0.0. Co-authored-by: Tyler Reckart <tylerreckart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Merging the 1.0.0 cut does not tag
v1.0.0today.version.ymlrunsbump_version.sh --mode autoafter CI is green. CMake is already1.0.0, ahead of tagv0.13.14, so the next version is1.0.0and the changelog heading is left alone. The script then rewrites a numericARBITER_VERSION=pin indocs/getting-started/local.md. That file shipsARBITER_VERSION=latest, the pattern matches zero times, andrequired=Falseonly skipped a missing file. The job exits before it can tag.The same failure already happened on the README merge (
e6a925b, version-bump run 38763846429), which was trying to cut0.13.15:A local fixture of the 1.0 tree (CMake
1.0.0, tagv0.13.14,## [1.0.0]already present,ARBITER_VERSION=latest) exits the same way.What changed
sub_onetreats zero matches as a skip when the pin is optional. A required pin that does not match once is still fatal. A numeric pin in that doc is still rewritten to the new tag.The fixture suite covers the 1.0 shape: next version
1.0.0,latestleft in place, no second changelog heading, and nochore(release)commit when the tree is already at that version.After this merges
The next green push to
mainstartsversion.yml. With CMake still ahead ofv0.13.14and this skip in place, that job tagsv1.0.0on that main SHA and dispatchesrelease.yml, which publishesarbiter-linux-x86_64.tar.gz,arbiter-macos-arm64.tar.gz, their.sha256files, andinstall.shas the GitHub Release titledarbiter v1.0.0. The run already queued for683e4cdchecks out the script that is onmainat job start, so it still fails unless this fix is what it checks out.