Use [:noconnect] on all cross-node sends#12
Merged
Merged
Conversation
Matches pg.erl's use of erlang:send/3 with [noconnect]. Without this flag, send/2 to a disconnected peer triggers a connection attempt that blocks the GenServer until the attempt times out or succeeds. With [:noconnect], the message is silently dropped if the peer isn't connected — the next nodeup will trigger a fresh discover/sync anyway, so nothing is lost. Applied to: - broadcast/2 (the main send loop for join/leave/update gossip) - init/1 discover broadcast to all known nodes - nodeup handler discover to the new node - handle_discover reply to a discovering peer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches pg.erl's use of
erlang:send/3with[noconnect]. Without this flag,send/2to a disconnected peer triggers a connection attempt that blocks the GenServer until the attempt times out or succeeds. With[:noconnect], the message is silently dropped if the peer isn't connected — the nextnodeupwill trigger a fresh discover/sync anyway, so nothing is lost.Applied to:
broadcast/2(the main send loop for join/leave/update gossip)init/1discover broadcast to all known nodesnodeuphandler discover to the new nodehandle_discoverreply to a discovering peerThis was part of PR #9 but landed after the squash-merge. Cherry-picked onto main.