Switch to rustls for reqwest for musl target#8
Merged
vishvananda merged 1 commit intomainfrom Jan 16, 2025
Merged
Conversation
vishvananda
changed the title
This makes cross-compilation much easier because it doesn't require an
openssl build.
It should be possible to build for musl using:
cargo build --target x86_64-unknown-linux-musl --no-default-features
wycats
approved these changes
Jan 16, 2025
| reqwest = { version = "0.12", default-features = false, features = ["blocking", "json", "rustls-tls"] } | ||
|
|
||
| [features] | ||
| default = ["reqwest/native-tls", "reqwest/blocking", "reqwest/json"] |
Contributor
There was a problem hiding this comment.
Nice. I originally was thinking it would make sense to have a musl feature, but keying it all on the target is great. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes cross-compilation much easier because it doesn't require an openssl build.